-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning (not only) in users' code #59
Conversation
Btw, why is the code from |
@sideeffffect that's a great question, the answer is - to make macro annotation a zero dependency case. The way it works: @ compile time the code generated by the However, this is not possible in Scala 3 (no annotations), that's why I implemented this See https://github.com/sbt/sbt-jni/blob/main/plugin/src/sbt-test/sbt-jni/simple-syntax/build.sbt#L8 |
But the code in both seems awfully similar. How much opportunity for code reuse/sharing do you think there is? |
@sideeffffect I don't think there is, we could try to think of smth in Scala 2.x I guess, but def macros also requires a dependency (I checked) 🤷 As time goes we are just going to drop macro annotation / replace it with some future Scala 3 annotations (if there would be any). I'd like to suggest to keep this old code "as is", just in case it is still useful for users. |
OK, let's merge this. |
Get rid of
and similar annoyances.